Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flow): query table schema&refactor #3943

Merged
merged 4 commits into from
May 15, 2024
Merged

feat(flow): query table schema&refactor #3943

merged 4 commits into from
May 15, 2024

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

added TableSource to get table name, id and schema from metasrv, and other minor refactor

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • added TableSource to help flow node get table name, id and schema from metasrv
  • refactor SourceSender to allow unbounded broadcast

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 15, 2024
@discord9 discord9 marked this pull request as ready for review May 15, 2024 03:32
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 189 lines in your changes are missing coverage. Please review.

Project coverage is 85.39%. Comparing base (15d7b97) to head (a9f16e8).
Report is 2 commits behind head on main.

❗ Current head a9f16e8 differs from pull request most recent head b4708c2. Consider uploading reports for the commit b4708c2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3943      +/-   ##
==========================================
- Coverage   85.77%   85.39%   -0.38%     
==========================================
  Files         968      970       +2     
  Lines      166463   166614     +151     
==========================================
- Hits       142782   142286     -496     
- Misses      23681    24328     +647

zhongzc
zhongzc approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, very readable PR! 😍

waynexia
waynexia approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

src/flow/src/adapter.rs Outdated Show resolved Hide resolved
src/flow/src/adapter/util.rs Outdated Show resolved Hide resolved
src/flow/src/adapter/table_source.rs Outdated Show resolved Hide resolved
@discord9 discord9 added this pull request to the merge queue May 15, 2024
Merged via the queue into GreptimeTeam:main with commit 97eb196 May 15, 2024
20 checks passed
@discord9 discord9 deleted the flow_p3_table_source branch May 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc zhongzc approved these changes

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield MichaelScofield is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@discord9 @fengjiachun @waynexia @zhongzc